-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File editor wont load files without an internet connection #3699
Comments
Adding a single data point - I cannot reproduce. Using HAOS 2024.7.3 and File Editor 5.8.0, I am not seeing the behavior you describe. The horizontal bar you describe is normal - that is where File Editor tells you what file you are viewing/editing - but I cannot reproduce the issue you are seeing from my side where the file does not load, and it does not tell you the file name on that bar - Selection dialog appears to be working the same as any other time, and no issues loading files System Information provided for comparative diagnosis. System Informationversion | core-2024.7.3 Home Assistant OS-- | -- installation_type | Home Assistant OS dev | false hassio | true docker | true user | root virtualenv | false python_version | 3.12.4 os_name | Linux os_version | 6.6.33-haos arch | x86_64 timezone | America/Chicago config_dir | /configHome Assistant Supervisor
Dashboards
Recorder
|
Hi, I didn't find the source code for the file-editor add-on here on GitHub. But if it indeed is OSS, you could potentially remove the dependencies by serving the Cloudflare JS locally. As you stated, The functionality shouldn't require an active connection to 3rd parties. It's also possible that the cdn portions are from https://github.com/ajaxorg/ace, which is used to power the File-editor. Good Luck. |
Who maintains this add-on? They're the ones that could look into fixing this privacy (and functionality) issue... Edit: Add-on info shows https://github.com/home-assistant/addons/tree/master/configurator as source. |
Yes, but do you actually see any source in there? The README.md states:
But i think we could circumvent that and help create a PR there that fixes the issue. |
The link I linked to was "official" and has commits from 7m and 10m ago versus 2 years for the link you sent. Going by official link and age. |
Yes @OdinVex, but taking a look at the offical repositories TBH. it's just a shitty documented repository, where you actually have to dig to find out what dependencies they are using. |
I see now, similar in concept to Arch's AUR's PKGBUILD files. |
For all, TLDR:This is a duplicate of: danielperna84/hass-configurator#177 which describes the situation! Check that out. The Source code responsible for the UI and the external CDN requests: danielperna84/hass-configurator WIP build(but stale) trying to get rid of CDN dependencies on the offline Branch. If we implement this offline functionality, we will get it into home assistant! |
+1 would be great to get this working totally offline |
As per above, this is an issue with/feature request for the upstream hass-configurator. Please track the issue on their end instead. Thanks! 👍 ../Frenck |
hilarious
…On Wed, 25 Sept 2024, 09:25 Franck Nijhof, ***@***.***> wrote:
As per above, this is an issue with/feature request for the upstream
hass-configurator. Please track the issue on their end instead.
Thanks! 👍
../Frenck
—
Reply to this email directly, view it on GitHub
<#3699 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZMQZP6MIK37LKWJA67DV3ZYJQNPAVCNFSM6AAAAABLMLY63SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZTGI3DMMRXHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@magiva Sorry? |
Describe the issue you are experiencing
I load file editor, select a file to load and nothing loads
the editor looks weird too with a blank horizontal bar top right, i can type in it but it doesnt do anything
Log:
INFO:2024-07-24 14:16:37,138:hass_configurator.configurator:172.30.32.2 - "GET /api/listdir?path=. HTTP/1.1" 200 -
INFO:2024-07-24 14:16:38,200:hass_configurator.configurator:127.0.0.1 - "GET / HTTP/1.1" 200 -
INFO:2024-07-24 14:16:40,234:hass_configurator.configurator:172.30.32.2 - "GET /api/file?filename=/homeassistant/configuration.yaml HTTP/1.1" 200 -
What type of installation are you running?
Home Assistant OS
Which operating system are you running on?
Home Assistant Operating System
Which add-on are you reporting an issue with?
File editor
What is the version of the add-on?
5.8.0
Steps to reproduce the issue
...
System Health information
There are currently no repairs available
Anything in the Supervisor logs that might be useful for us?
Anything in the add-on logs that might be useful for us?
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: