diff --git a/supervisor/backups/backup.py b/supervisor/backups/backup.py index 334bd6906bd..9390919bb9a 100644 --- a/supervisor/backups/backup.py +++ b/supervisor/backups/backup.py @@ -162,12 +162,12 @@ def folders(self) -> list[str]: @property def repositories(self) -> list[str]: - """Return backup date.""" + """Return add-on store repositories.""" return self._data[ATTR_REPOSITORIES] @repositories.setter def repositories(self, value: list[str]) -> None: - """Set backup date.""" + """Set add-on store repositories.""" self._data[ATTR_REPOSITORIES] = value @property @@ -286,7 +286,7 @@ def __eq__(self, other: Any) -> bool: or k not in other._data or self._data[k] != other._data[k] ): - _LOGGER.debug( + _LOGGER.info( "Backup %s and %s not equal because %s field has different value: %s and %s", self.slug, other.slug, diff --git a/supervisor/store/validate.py b/supervisor/store/validate.py index e21982ead5b..7582b982726 100644 --- a/supervisor/store/validate.py +++ b/supervisor/store/validate.py @@ -28,6 +28,15 @@ ) +def ensure_builtin_repositories(addon_repositories: list[str]) -> list[str]: + """Ensure builtin repositories are in list. + + Note: This should not be used in validation as the resulting list is not + stable. This can have side effects when comparing data later on. + """ + return list(set(addon_repositories) | BUILTIN_REPOSITORIES) + + def validate_repository(repository: str) -> str: """Validate a valid repository.""" if repository in [StoreType.CORE, StoreType.LOCAL]: @@ -44,13 +53,7 @@ def validate_repository(repository: str) -> str: return repository -def ensure_builtin_repositories(addon_repositories: list[str]) -> list[str]: - """Ensure builtin repositories are in list.""" - return list(set(addon_repositories) | BUILTIN_REPOSITORIES) - - -# pylint: disable=no-value-for-parameter -repositories = vol.All([validate_repository], vol.Unique(), ensure_builtin_repositories) +repositories = vol.All([validate_repository], vol.Unique()) SCHEMA_STORE_FILE = vol.Schema( {