Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release CI #252

Closed
TylerHelmuth opened this issue May 23, 2023 · 2 comments · Fixed by #253
Closed

Fix release CI #252

TylerHelmuth opened this issue May 23, 2023 · 2 comments · Fixed by #253
Labels
type: bug Something isn't working

Comments

@TylerHelmuth
Copy link
Contributor

With the bump to chart releaser 1.5.0 we lost the ability to do cr index with an ssh git remote, which is the type of remote that circleci uses. As a result, the circleci job could not run the cr index step of the release. An attempt to fix this issue was made with #250, but it was unsuccessful. As a result, we have had to do the cr index step locally, which is annoying.

We need to update our release script or the CircleCI job so that it plays nicely with chart releaser.
@TylerHelmuth TylerHelmuth added the type: bug Something isn't working label May 23, 2023
@TylerHelmuth
Copy link
Contributor Author

Doing some testing, it seems CircleCI is replacing any instance of and https remote with the ssh remote when running the git remote command.

In CircleCI when I run

git remote add origin-https "https://github.com/$GIT_REPOSITORY_OWNER/$GIT_REPOSITORY_NAME.git"
git remote get-url --push origin-https
git remote -v

the output is

ssh://[email protected]/honeycombio/helm-charts.git
origin	[email protected]:honeycombio/helm-charts.git (fetch)
origin	[email protected]:honeycombio/helm-charts.git (push)
origin-https	ssh://[email protected]/honeycombio/helm-charts.git (fetch)
origin-https	ssh://[email protected]/honeycombio/helm-charts.git (push)

@TylerHelmuth TylerHelmuth mentioned this issue May 23, 2023
Merged
@TylerHelmuth
Copy link
Contributor Author

Issue was that circleci's global git config for the job had url.ssh://[email protected]=https://github.com/.

TylerHelmuth added a commit that referenced this issue Jun 9, 2023
@TylerHelmuth
fix: Unset insteadOf in git config of release job (#253)
eeb0ade 
## Which problem is this PR solving?

- Closes #252

## Short description of the changes

- updates the release script to unset an `insteadOf` config in the
global git config of the circleci job.

## How to verify that this has the expected result

Tested that the git remote is set properly. Can't test the actual `cr
index` command until the next release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Unset insteadOf in git config of release job honeycombio/helm-charts
1 participant
@TylerHelmuth