Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICFolderDialog has to many responsibilities #349

Open
MrHenrik opened this issue Jul 30, 2020 · 1 comment
Open

ICFolderDialog has to many responsibilities #349

MrHenrik opened this issue Jul 30, 2020 · 1 comment
Labels
discussion Needs to be discussed with the team good first issue Good possibility to get an overview of the system. Great point to start for the new team! refactor

Comments

@MrHenrik
Copy link
Contributor

Refactor the UI Component in multiple smaller components
@shm0sby
Copy link

shm0sby commented Aug 7, 2020

We have hinted to a few possible refactorings by naming categories accordingly. With them you could split the ICFolder Dialog into multiple components that are dedicated to fewer responsibilities. For example one for the account menu on the upper left in the UI, one for the folder menu below, etc. This is a good issue to discuss in your team and have a few thoughts about what you learnt in your Softwarearchitecture lecture.

@shm0sby shm0sby added discussion Needs to be discussed with the team good first issue Good possibility to get an overview of the system. Great point to start for the new team! labels Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion Needs to be discussed with the team good first issue Good possibility to get an overview of the system. Great point to start for the new team! refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shm0sby @JuliaJoch @MrHenrik