Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move "notification" into "history" when answered #260

Closed
1 of 5 tasks
snailcato opened this issue Jan 11, 2023 · 1 comment · Fixed by #391
Closed
1 of 5 tasks

move "notification" into "history" when answered #260

snailcato opened this issue Jan 11, 2023 · 1 comment · Fixed by #391
Assignees
@IsThisTheCrustyCrab-was-taken @JakobTimm
Labels
2 Second Priority BP-TF BP Friedrich Needs UI Mockup Project Backlog
Milestone
Notification System

Comments

@snailcato
Copy link
Collaborator

snailcato commented Jan 11, 2023 •
edited by JakobTimm
Loading

User stories

As a user I want only relevant notifications on top of the page, to know what's still to answer.

Dependencies

Depends on:

UI Mockup

[UI Mockup]

Context

pickup reminder remains in "notifications" till item pick up happened or the time ist up

Acceptance Criteria

  • moves following notifications into history, when action was taken
  • ... lend requests
  • ... return request
  • ... pickup reminder
  • history shows which action was taken by the user
@snailcato snailcato added the in preparation This issue has not been finalized, POs need to further specify this issue label Jan 11, 2023
@snailcato snailcato added this to the Notification System milestone Jan 11, 2023
@snailcato snailcato added Needs UI Mockup BP-TF BP Friedrich 2 Second Priority Clarification needed Issue needs to be more specific Project Backlog and removed in preparation This issue has not been finalized, POs need to further specify this issue Clarification needed Issue needs to be more specific labels Jan 11, 2023
@JanFehse JanFehse assigned JanFehse and unassigned JanFehse Jan 13, 2023
@JakobTimm JakobTimm self-assigned this Jan 16, 2023
@JanFehse
Copy link
Collaborator

JanFehse commented Jan 17, 2023 •
edited
Loading

Maybe Refactor the return requests into notifications_controller same as we did for lend requests
If they stay in item, the current method of searching for the correct request can be wrong as the notification will not be the only when it has the item. Just give the notification_id as a parameter in routes and then use it in the function.
Please add a test for this

@snailcato snailcato mentioned this issue Jan 17, 2023
Closed
3 tasks
@JakobTimm JakobTimm mentioned this issue Feb 1, 2023
Merged
5 tasks
@JakobTimm JakobTimm linked a pull request Feb 1, 2023 that will close this issue
Feature/tf+ 260 move notification into history when answered #391
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IsThisTheCrustyCrab-was-taken IsThisTheCrustyCrab-was-taken

@JakobTimm JakobTimm

Labels
2 Second Priority BP-TF BP Friedrich Needs UI Mockup Project Backlog
Projects
None yet
Milestone
Notification System
Development

Successfully merging a pull request may close this issue.

Feature/tf+ 260 move notification into history when answered hpi-swt2/bookkeeper-portal-blue
4 participants
@JanFehse @IsThisTheCrustyCrab-was-taken @snailcato @JakobTimm