Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kbravh/obsidian-tweet-to-markdown
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: hraftery/obsidian-tweet-to-markdown
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 7 files changed
  • 1 contributor

Commits on Nov 20, 2022

  1. Add Poll Tweets functionality

    See README changes for a description of the new functionality. The implementation is at the "get it working stage", not at the "get it right" stage. I'm also not a Typescript developer and have definitely committed some code violations. But it's powerful functionality and I'd like to get it out there early.
    
    Known issues:
      - Keys from https://ttm.kbravh.dev are not supported so you need a Twitter Developer bearer token. Which was actually a piece of cake when I tried it.
      - If settings like "noteLocation" or "pollFilename" are empty, strange things will happen. Defaults are not enforced.
      - An error like "images failed to download" sometimes appears. But images seem to be downloading. More investigation necessary.
      - There is very little feedback on progress to the user. This is challenging to do well.
      - The process cannot be interrupted (or monitored, easily), so mistakes can result in a lot of downloaded tweets!
      - Every Tweet duplicates a lot of front matter. On reflection, this is still better than any alternative I could think of.
      - Speaking of, the "fetch new tweets" functionality relies on frontmatter being present and will quietly download all tweets again if it is not there.
      - There is now a lot of code repetition. This is so my additions are well contained, rather than modifying too much existing code at this stage.
      - Testing, and tests, are basically non-existent at this stage.
    hraftery committed Nov 20, 2022
    Copy the full SHA
    22ff5bd View commit details
Loading