Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy support #1

Closed
rbozan opened this issue Feb 8, 2024 · 2 comments · Fixed by #2
Closed

Proxy support #1

rbozan opened this issue Feb 8, 2024 · 2 comments · Fixed by #2
Assignees
@hs-CN
Labels
enhancement New feature or request

Comments

@rbozan
Copy link

rbozan commented Feb 8, 2024

Hi, is there a way to get proxy support in this crate? So I can proxy the Websocket requests through my proxy?
@hs-CN
Copy link
Owner

hs-CN commented Feb 9, 2024

hi, thanks for the issue. I've read the documentation for isahc and tungstenite. isahc support http_proxy, https_proxy and socks4/5 proxy, so get_voice_list can easily support all proxy types.
Tungstenite doesn't seem to have such support #177 The good thing is that Tungstenite allows us to use our own TCP/TLS stream, and I might be able to establish a proxy connection before starting the websocket handshake.
But it's going to be a busy time starting tomorrow when we have Chinese New Year, so I'll deal with that in a few days.

@hs-CN hs-CN closed this as completed Feb 9, 2024
@hs-CN hs-CN reopened this Feb 9, 2024
@hs-CN hs-CN self-assigned this Feb 9, 2024
@hs-CN hs-CN added the enhancement New feature or request label Feb 9, 2024
@hs-CN hs-CN linked a pull request Feb 21, 2024 that will close this issue
add proxy support #2
Merged
6 tasks
@hs-CN hs-CN closed this as completed in #2 Mar 1, 2024
@hs-CN
Copy link
Owner

hs-CN commented Mar 1, 2024

fixed on #2 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hs-CN hs-CN

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add proxy support hs-CN/msedge-tts
2 participants
@rbozan @hs-CN