Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(pattern): 将x,y等类似表现改为实际表现名 #30

Open
CarmJos opened this issue Jan 16, 2025 · 1 comment
Open

chore(pattern): 将x,y等类似表现改为实际表现名 #30

CarmJos opened this issue Jan 16, 2025 · 1 comment

Comments

@CarmJos
Copy link

CarmJos commented Jan 16, 2025

现在的x,y的表现是先列后行，而非先行后列，有点违背mc玩家/开发者的直觉，建议修改为：

  • x -> column
  • y -> row

并同时调整其方法中的顺序，以方便快速开发。
@huanmeng-qwq
Copy link
Owner

huanmeng-qwq commented Jan 16, 2025 •
edited
Loading

感谢您提出的建议
经过考虑Slot#ofGame和Slot#ofBukkit方法的参数顺序改为(row, column)
373e851

huanmeng-qwq added a commit that referenced this issue Jan 16, 2025
@huanmeng-qwq
refactor(gui): 在PageSlot中添加多个of方法，简化PageSlot的创建 #30
8a24184 
GuiManager#close后将instance设置为null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CarmJos @huanmeng-qwq