Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create internal R function to transform pmf model-output data to scoringutils-compatible format #24

Closed
2 tasks
bsweger opened this issue Apr 3, 2024 · 1 comment · Fixed by #45
Closed
2 tasks
Assignees

Comments

@bsweger
Copy link
Collaborator

bsweger commented Apr 3, 2024

(formerly part of #12)

Similar to other hubverse-supported output types (e.g., #23, #24, #25), we will need an internal transformation function in hubEvals to handle transforming pmf model-output data into the scoringutils forecast object: https://epiforecasts.io/scoringutils/dev/reference/as_forecast.html.

However, scoringutils does not yet support the pmf model output type (related issue), so we're not yet able to do this data conversion.

In the meantime, we can create the internal function for transforming pmf output data, but use it to alert hubverse users that pmf scoring is not yet implemented (instead of doing the actual data transformation).

This is not a user-facing function. Instead, it will be invoked by the publicly-accessible function described in #11.

Definition of done:

@bsweger bsweger changed the title Write an R function to transform pmf model-output data to scoringutils-compatible format Create internal R function to transform pmf model-output data to scoringutils-compatible format Apr 3, 2024
@bsweger bsweger added this to the add scoring to hubverse milestone Apr 3, 2024
@bsweger bsweger changed the title Create internal R function to transform pmf model-output data to scoringutils-compatible format Create internal R "stub" function to transform pmf model-output data to scoringutils-compatible format Apr 3, 2024
@elray1 elray1 moved this from Todo to Up Next in hubverse Development overview Aug 16, 2024
@elray1 elray1 changed the title Create internal R "stub" function to transform pmf model-output data to scoringutils-compatible format Create internal R function to transform pmf model-output data to scoringutils-compatible format Aug 16, 2024
@elray1
Copy link
Contributor

elray1 commented Aug 16, 2024

Noting that the pmf functionality is now in scoringutils

@elray1 elray1 self-assigned this Aug 16, 2024
@elray1 elray1 moved this from Up Next to In Progress in hubverse Development overview Aug 16, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in hubverse Development overview Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants