Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divide sklearn generation script into tasks #97

Open
merveenoyan opened this issue Aug 31, 2022 · 2 comments
Open

Divide sklearn generation script into tasks #97

merveenoyan opened this issue Aug 31, 2022 · 2 comments
Assignees

Comments

@merveenoyan
Copy link
Contributor

merveenoyan commented Aug 31, 2022

Currently sklearn generation script takes only version as argument. It would be nice to put an option to run for a given task separately given we might add more tasks and it's cumbersome to run it for all tasks and push tons of models to skops-tests every time.
It would be nice if we could do:

def main(version, task):
    ...

if __name__ == "__main__":
    sklearn_version = sys.argv[1]
    task = sys.argv[2]
    main(sklearn_version, task)

It was a minor annoyance, I had to run the script and in the middle of the run I uploaded 5 models that I didn't need, and got 503.
Feel free to ignore if it's not good :')
@adrinjalali @BenjaminBossan

@BenjaminBossan
Copy link
Member

Yes, the waiting time is annoying. I think it's good to have the option to choose a specific task. Ideally, there should still be the possibility to run all tasks at once.

@adrinjalali
Copy link
Contributor

Sounds good to me too.

@merveenoyan merveenoyan self-assigned this Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants