From fb4ecdc6659df8f1a37c93d4c64ff47f51d40f00 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9mentine=20Fourrier?= <22726840+clefourrier@users.noreply.github.com> Date: Mon, 16 Dec 2024 14:32:02 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Nathan Habib <30601243+NathanHB@users.noreply.github.com> Co-authored-by: Albert Villanova del Moral <8515462+albertvillanova@users.noreply.github.com> --- src/lighteval/main_endpoint.py | 1 - src/lighteval/models/transformers/transformers_model.py | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/lighteval/main_endpoint.py b/src/lighteval/main_endpoint.py index 470374e09..a9c23f481 100644 --- a/src/lighteval/main_endpoint.py +++ b/src/lighteval/main_endpoint.py @@ -98,7 +98,6 @@ def openai( """ from lighteval.logging.evaluation_tracker import EvaluationTracker - # from lighteval.models.model_input import GenerationParameters from lighteval.models.endpoints.openai_model import OpenAIModelConfig from lighteval.models.model_input import GenerationParameters from lighteval.pipeline import EnvConfig, ParallelismManager, Pipeline, PipelineParameters diff --git a/src/lighteval/models/transformers/transformers_model.py b/src/lighteval/models/transformers/transformers_model.py index e66a2d70a..69af4733b 100644 --- a/src/lighteval/models/transformers/transformers_model.py +++ b/src/lighteval/models/transformers/transformers_model.py @@ -238,7 +238,7 @@ def get_model_sha(self): @dataclass class BaseModelConfig(TransformersModelConfig): def __post_init__(self): - super() + super().__post_init__() logger.warning( "Careful, BaseModelConfig is deprecated and will be removed, you should use TransformersModelConfig instead!"