Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add future import for Py < 3.10 #35666

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add future import for Py < 3.10 #35666

wants to merge 3 commits into from

Conversation

Rocketknight1
Copy link
Member

One of our files uses X | None style types, which requires from __future__ import annotations on versions of Python < 3.10. This PR adds the import

Fixes #35639

@Rocketknight1 Rocketknight1 requested a review from gante as a code owner January 13, 2025 16:08
@Rocketknight1
Copy link
Member Author

Scanned the repo and found the same issue in convert_olmo2_weights_to_hf.py, so I made the fix there as well

@Rocketknight1
Copy link
Member Author

cc @ArthurZucker for review!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thank you for the fix 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change in v4.48.0 and Python 3.9
3 participants