Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FA2 support for Aria #35670

Open
molbap opened this issue Jan 13, 2025 · 1 comment
Open

FA2 support for Aria #35670

molbap opened this issue Jan 13, 2025 · 1 comment

Comments

@molbap
Copy link
Contributor

molbap commented Jan 13, 2025

Currently, Aria does not support FA2 in its modeling code:

_supports_flash_attn_2 = False

However the reference checkpoint for the Aria model does set attn_implementation to FA2: https://huggingface.co/rhymes-ai/Aria/blob/104c6548d7da08fc3a30c4232d35cc9fb3239942/config.json#L36

So the modeling code on transformers side should be updated to support it. It currently causes errors on the CI and I think it's due to this mismatch.

cc @aymeric-roucher @zucchini-nlp

@zucchini-nlp
Copy link
Member

I don't have write access to the repo, but I guess there should be a colab in slack to ping the authors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants