Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] sold tab under profile shows bought items #207

Open
holkexyz opened this issue Aug 21, 2024 · 3 comments · Fixed by #208
Open

[bug] sold tab under profile shows bought items #207

holkexyz opened this issue Aug 21, 2024 · 3 comments · Fixed by #208
Labels
bug Something isn't working

Comments

@holkexyz
Copy link
Member

I just bought a fraction and under the profile it is shown under bought as well as sell

Image
@bitbeckers bitbeckers self-assigned this Sep 2, 2024
@bitbeckers
Copy link
Contributor

Issue is in the indexer:

    seller: getAddress(bid.params.bidRecipient),
        buyer: getAddress(bid.params.bidUser),

In the case of the takerBid event handling, the buyer is the tx.from

@bitbeckers bitbeckers transferred this issue from hypercerts-org/hypercerts-app Sep 2, 2024
@bitbeckers bitbeckers mentioned this issue Sep 2, 2024
Merged
@bitbeckers bitbeckers linked a pull request Sep 2, 2024 that will close this issue
fix(sales): get correct address for buyer and seller #208
Merged
@bitbeckers
Copy link
Contributor

Fixed on testnet.hypercerts org

@github-project-automation github-project-automation bot moved this from In progress to Done in Hypercerts dev team daily ops Sep 2, 2024
@bitbeckers bitbeckers removed their assignment Sep 2, 2024
@holkexyz
Copy link
Member Author

holkexyz commented Oct 4, 2024

This still happens for me (observed on mainnet)

@holkexyz holkexyz reopened this Oct 4, 2024
@bitbeckers bitbeckers added the bug Something isn't working label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Hypercerts dev team daily ops
Status: In review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(sales): get correct address for buyer and seller hypercerts-org/hypercerts-indexer
2 participants
@bitbeckers @holkexyz