Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Graph] Add chainId to hypercerts ID in graph. #1235

Closed
bitbeckers opened this issue Dec 12, 2023 · 3 comments
Closed

[Graph] Add chainId to hypercerts ID in graph. #1235

bitbeckers opened this issue Dec 12, 2023 · 3 comments
Assignees

Comments

@bitbeckers
Copy link
Contributor

Describe the feature you'd like to request

When I load a hypercert from the Graph based on the ID, I expect to also have the chainID in there. This makes it easy for users and developers to identify on what chain the hypercert lives

Describe the solution you'd like

https://hypercerts.org/app/view#claimId=0x822f17a9a5eecfd66dbaff7946a8071c265d1d07-16605439223374876078549217468062856950841344

Should become

https://hypercerts.org/app/view#claimId=[0xa]-0x822f17a9a5eecfd66dbaff7946a8071c265d1d07-16605439223374876078549217468062856950841344

or

https://hypercerts.org/app/view#claimId=[10]-0x822f17a9a5eecfd66dbaff7946a8071c265d1d07-16605439223374876078549217468062856950841344

Describe alternatives you've considered

.

@Jipperism
Copy link
Contributor

I would prefer using 10 instead of 0xa.

Important to remember to update all entries in supabase tables that use claimIds.

@bitbeckers
Copy link
Contributor Author

bitbeckers commented Dec 19, 2023

Let's also consider renaming it hypercertId because we already have claimId in the contracts and they're not the same

@bitbeckers
Copy link
Contributor Author

In #1283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants