Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Remove hard-coded Node version #596

Open
ryscheng opened this issue Apr 26, 2023 · 3 comments
Open

[CI] Remove hard-coded Node version #596

ryscheng opened this issue Apr 26, 2023 · 3 comments
Labels

Comments

@ryscheng
Copy link
Member

What is it?

In GitHub actions (ci-default.yml), Fleek, and Cloudflare, we are hard-coding a node version of 18.15.0 right now because of this hardhat bug
NomicFoundation/hardhat#3877

Whenever this gets fixed, we should move everything back to LTS whereever possible

@ryscheng
Copy link
Member Author

From the looks of the comments, the hardhat devs are still debugging this as of last week. Going to de-prioritize until they have a fix

@bitbeckers bitbeckers changed the title Remove hard-coded Node version [CI] Remove hard-coded Node version Oct 4, 2023
@bitbeckers bitbeckers assigned bitbeckers and unassigned ryscheng Oct 4, 2023
@bitbeckers
Copy link
Contributor

Issue fixed in hardhat 2.16.1 so should be good to upgrade and go

@bitbeckers
Copy link
Contributor

Prepare for a rabbithole:

  • GHA actions currently require frozen lockfile
  • packages are using pnpm 9, GHA pnpm 8
  • Errors our on frozen lockfile
  • Updating to pnpm 9 introduces node-gyp-builder missing error
  • Most dependencies in -at least- contracts are outdated

Conclusion: Need to spend some time on updating all dependencies and validating that GHA still run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

4 participants