-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(custom-checks): fix dependencies being inconsistent phase 5 #3688
Labels
dependent
enhancement
New feature or request
Keychain
Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves.
Comments
jagpreetsinghsasan
added
enhancement
New feature or request
Keychain
Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves.
labels
Dec 10, 2024
This PR/issue depends on:
|
ruzell22
added a commit
to ruzell22/cactus
that referenced
this issue
Jan 9, 2025
Primary Changes --------------- 1. Fixed dependencies on targeted packages: packages/cactus-plugin-keychain-azure-kv packages/cactus-plugin-keychain-google-sm packages/cactus-plugin-keychain-memory packages/cactus-plugin-keychain-memory-wasm packages/cactus-plugin-keychain-vault Fixes: hyperledger-cacti#3688 Signed-off-by: ruzell22 <[email protected]>
5 tasks
ruzell22
added a commit
to ruzell22/cactus
that referenced
this issue
Jan 9, 2025
Primary Changes --------------- 1. Fixed dependencies on targeted packages: packages/cactus-plugin-keychain-azure-kv packages/cactus-plugin-keychain-google-sm packages/cactus-plugin-keychain-memory packages/cactus-plugin-keychain-memory-wasm packages/cactus-plugin-keychain-vault Fixes: hyperledger-cacti#3688 Signed-off-by: ruzell22 <[email protected]>
ruzell22
added a commit
to ruzell22/cactus
that referenced
this issue
Jan 9, 2025
Primary Changes --------------- 1. Fixed dependencies on targeted packages: packages/cactus-plugin-keychain-azure-kv packages/cactus-plugin-keychain-google-sm packages/cactus-plugin-keychain-memory packages/cactus-plugin-keychain-memory-wasm packages/cactus-plugin-keychain-vault Fixes: hyperledger-cacti#3688 Signed-off-by: ruzell22 <[email protected]>
petermetz
pushed a commit
to ruzell22/cactus
that referenced
this issue
Jan 29, 2025
Primary Changes --------------- 1. Fixed dependencies on targeted packages: packages/cactus-plugin-keychain-azure-kv packages/cactus-plugin-keychain-google-sm packages/cactus-plugin-keychain-memory packages/cactus-plugin-keychain-memory-wasm packages/cactus-plugin-keychain-vault Fixes: hyperledger-cacti#3688 Signed-off-by: ruzell22 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependent
enhancement
New feature or request
Keychain
Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves.
Description
As a developer, I want to fix the dependency versions being inconsistent across packages in Cacti.
Targeted packages:
Depends on #3612
Solution:
Run the script tools/custom-checks/check-dependency-version-consistency.ts with
fix: true
, note down the changes for the abovetargeted packages
, stash and drop the changes, and proceed with fixing just those targeted packages.Possible errors
To test this scenario, simply create a PR for this task fixing only the targeted packages and have a lookout on CI for any failing tests. If we have any failing tasks, we should fix them as a part of this task
>=1.2.3
, fix the root package which has this sort of version and then include that in the conflicting package (a 2 way solution)Acceptance Criteria
The text was updated successfully, but these errors were encountered: