From da5afed212f573657a8100a045fdc50f6381a1d1 Mon Sep 17 00:00:00 2001 From: Peter Somogyvari Date: Tue, 26 Nov 2024 14:01:07 -0800 Subject: [PATCH] docs(readme): fix container image build cmds: drop / from branch names Previously if you executed the image build commands that use the branch name to produce container image tag names then you received an error if your branch name contained a forward slash (/) which is common for people who use VSCode extensions for managing branches related to pull requests. The new commands are using `sed` to remove the forward slashes from the branch names and replace them with underscores (_) so that the container image tags are valid. Signed-off-by: Peter Somogyvari --- examples/cactus-example-supply-chain-backend/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/cactus-example-supply-chain-backend/README.md b/examples/cactus-example-supply-chain-backend/README.md index e2f8b97f62..d676ede6e2 100644 --- a/examples/cactus-example-supply-chain-backend/README.md +++ b/examples/cactus-example-supply-chain-backend/README.md @@ -32,7 +32,7 @@ DOCKER_BUILDKIT=1 docker build --file \ ./examples/cactus-example-supply-chain-backend/Dockerfile \ . \ --tag scaeb \ - --tag ghcr.io/hyperledger/cactus-example-supply-chain-app:$(git describe --contains --all HEAD)_$(git rev-parse --short HEAD)_$(date -u +"%Y-%m-%dT%H-%M-%SZ") + --tag ghcr.io/hyperledger/cactus-example-supply-chain-app:$(git describe --contains --all HEAD | sed -r 's,/,-,g')_$(git rev-parse --short HEAD)_$(date -u +"%Y-%m-%dT%H-%M-%SZ") # Run the built image with ports mapped to the host machine as you see fit # The --privileged flag is required because we use Docker-in-Docker for pulling