Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex using google re to strip off comments in sql statement #953

Open
naronchen opened this issue Jan 7, 2025 · 0 comments
Open

Regex using google re to strip off comments in sql statement #953

naronchen opened this issue Jan 7, 2025 · 0 comments
Labels

Comments

@naronchen
Copy link
Contributor

naronchen commented Jan 7, 2025

In QueryHelper::FormatQuery() currently we just use \n to escape comments at the end.

maybe a a better way is to use the google re to strip off comments.

https://stackoverflow.com/questions/9690448/regular-expression-to-remove-comments-from-sql-statement

can use this as a reference here.

@naronchen naronchen assigned naronchen and unassigned naronchen Jan 7, 2025
@naronchen naronchen added the ecdb label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant