Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hierarchies: Look into exposing rxjs types in FilteringHierarchyDefinition #784

Open
grigasp opened this issue Nov 19, 2024 · 0 comments
Open

Comments

@grigasp
Copy link
Member

grigasp commented Nov 19, 2024

At the moment FilteringHierarchyDefinition implements HierarchyDefinition, which is a public type and, because of that, we don't want it to expose rxjs types. As a result, FilteringHierarchyDefinition has to convert all rxjs stuff to promises, which make it less efficient.

Maybe we could do this:

  • create an rxjs-aware hierarchy definition,
  • make imodel hierarchy provider use the rxjs one,
  • have an internal wrapper to map public hierarchy definition into the rxjs one,
  • change FilteringHierarchyDefinition to implement rxjs definition rather than the public one.

Need to see if that helps performance / code cleanliness / something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants