Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree Widget: Add support for react 18 #672

Closed
saskliutas opened this issue Oct 16, 2023 · 3 comments · Fixed by #728
Closed

Tree Widget: Add support for react 18 #672

saskliutas opened this issue Oct 16, 2023 · 3 comments · Fixed by #728
Assignees
Labels
enhancement New feature or request tree widget Tree widget or its components related issues

Comments

@saskliutas
Copy link
Member

Tree widget does not work with react 18 in StrictMode due to double rendering.

@saskliutas saskliutas added the tree widget Tree widget or its components related issues label Oct 16, 2023
@saskliutas saskliutas self-assigned this Oct 17, 2023
@muthubentley
Copy link

@saskliutas All the below packages doesnt have react 18 as their peer dependency.

  1. @itwin/breakdown-trees-react
  2. @itwin/measure-tools-react
  3. @itwin/property-grid-react
  4. @itwin/tree-widget-react

All of them belongs to this repo. Will you be able to fix all of them with this issue or do you need a separate issue for fixing each package?

@grigasp
Copy link
Member

grigasp commented Oct 20, 2023

@saskliutas All the below packages doesnt have react 18 as their peer dependency.

  1. @itwin/breakdown-trees-react
  2. @itwin/measure-tools-react
  3. @itwin/property-grid-react
  4. @itwin/tree-widget-react

All of them belongs to this repo. Will you be able to fix all of them with this issue or do you need a separate issue for fixing each package?

@muthubentley I believe it's best if we have an issue per package. I filed one for the property grid.

Note: We don't own all the mentioned packages, so we're only going to look into tree-widget-react and property-grid-react. Other teams will need to look into others (adding @aruniverse).

@grigasp grigasp added the enhancement New feature or request label Oct 20, 2023
@muthubentley
Copy link

Thanks @grigasp
Created new issues for @itwin/breakdown-trees-react and @itwin/measure-tools-react
#677
#678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tree widget Tree widget or its components related issues
Projects
None yet
3 participants