Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error logging limited #131

Closed
landonreed opened this issue Dec 11, 2018 · 2 comments
Closed

Error logging limited #131

landonreed opened this issue Dec 11, 2018 · 2 comments
Assignees
Labels

Comments

@landonreed
Copy link
Contributor

Issue by evansiroky
Sunday Aug 12, 2018 at 03:15 GMT
Originally opened as catalogueglobal#112


Round 1 of error logging refactor. Not as many changes as #108.


evansiroky included the following code: https://github.com/catalogueglobal/datatools-server/pull/112/commits

@landonreed landonreed self-assigned this Dec 11, 2018
@landonreed
Copy link
Contributor Author

Comment by codecov-io
Sunday Aug 12, 2018 at 03:21 GMT


Codecov Report

❗ No coverage uploaded for pull request base (dev@4b510bf). Click here to learn what that means.
The diff coverage is 11.57%.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev    #112   +/-   ##
=====================================
  Coverage       ?   5.13%           
  Complexity     ?      91           
=====================================
  Files          ?     129           
  Lines          ?    6751           
  Branches       ?     880           
=====================================
  Hits           ?     347           
  Misses         ?    6379           
  Partials       ?      25
Impacted Files Coverage Δ Complexity Δ
...nveyal/datatools/common/status/MonitorableJob.java 0% <ø> (ø) 0 <0> (?)
...ols/editor/controllers/api/SnapshotController.java 0% <0%> (ø) 0 <0> (?)
...main/java/com/conveyal/gtfs/GraphQLController.java 0% <0%> (ø) 0 <0> (?)
...ols/manager/controllers/api/ProjectController.java 10.45% <0%> (ø) 2 <0> (?)
...atools/manager/controllers/api/UserController.java 7.77% <0%> (ø) 2 <0> (?)
.../datatools/manager/controllers/DumpController.java 0% <0%> (ø) 0 <0> (?)
...atools/manager/controllers/api/NoteController.java 5.55% <0%> (ø) 2 <0> (?)
.../manager/controllers/api/DeploymentController.java 0% <0%> (ø) 0 <0> (?)
...anager/controllers/api/OrganizationController.java 15.38% <0%> (ø) 2 <0> (?)
...ools/manager/controllers/api/StatusController.java 13.04% <0%> (ø) 2 <0> (?)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b510bf...f4f49bf. Read the comment docs.

@landonreed
Copy link
Contributor Author

Comment by evansiroky
Saturday Oct 13, 2018 at 05:35 GMT


The latest PR comments should be addressed and this should be ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant