Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(polars): add ArrayStringJoin op #10638

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

IndexSeek
Copy link
Member

Description of changes

Adds support for the ArrayStringJoin operation for the Polars backend.

I tried my initial implementation using polars.Expr.str.join, but it seemed it needed polars.Expr.list.join instead.

Issues closed

@github-actions github-actions bot added tests Issues or PRs related to tests polars The polars backend labels Dec 31, 2024
@cpcloud cpcloud added this to the 10.0 milestone Dec 31, 2024
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! I love the tiny, incremental PRs!

@cpcloud cpcloud merged commit 42dd858 into ibis-project:main Dec 31, 2024
87 checks passed
@IndexSeek
Copy link
Member Author

Sweet! I love the tiny, incremental PRs!

Those 50+ file PRs from adding a new backend are much bigger :) I try to find low-hanging fruit missing operations haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
polars The polars backend tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants