From cc3fdc1fcb053153e95322b9c989216e817313ce Mon Sep 17 00:00:00 2001 From: Derick Montague Date: Tue, 27 Oct 2020 08:21:20 -0500 Subject: [PATCH] Update failing unit tests - Add babel plugin to handle Jest import of SVG. Without plugin the test fails with a require.context() is undefined - Update snapshot tests that have changed - Removed globals from .eslintrc.js that were needed prior to migrating from Mocha and Chai to Jest Signed-off-by: Derick Montague Change-Id: Ibd01d2e629b5ecb47d072e277e4e9b5ae5c5f001 --- .eslintrc.js | 4 - babel.config.js | 5 + package-lock.json | 9 + package.json | 1 + tests/unit/AppHeader.spec.js | 1 + .../unit/__snapshots__/AppHeader.spec.js.snap | 57 +- .../__snapshots__/AppNavigation.spec.js.snap | 1000 +++++++++-------- 7 files changed, 597 insertions(+), 480 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index fe716f06c2..502e87a0cc 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -19,10 +19,6 @@ module.exports = { parserOptions: { parser: 'babel-eslint', }, - globals: { - expect: true, - sinon: true, - }, overrides: [ { files: [ diff --git a/babel.config.js b/babel.config.js index b8daaabcf8..073c338396 100644 --- a/babel.config.js +++ b/babel.config.js @@ -1,3 +1,8 @@ module.exports = { presets: [['@vue/cli-plugin-babel/preset', { useBuiltIns: 'entry' }]], + env: { + test: { + plugins: ['transform-require-context'], + }, + }, }; diff --git a/package-lock.json b/package-lock.json index c0a5a1d00a..696938133f 100644 --- a/package-lock.json +++ b/package-lock.json @@ -3682,6 +3682,15 @@ "babel-types": "^6.26.0" } }, + "babel-plugin-transform-require-context": { + "version": "0.1.1", + "resolved": "https://registry.npmjs.org/babel-plugin-transform-require-context/-/babel-plugin-transform-require-context-0.1.1.tgz", + "integrity": "sha512-4ceqYOtzgmq4/QsB8dP7pUrUOCjY/jrRYdt7YkIOWHxtGDQbcf6YZDyLCiPQf6KsEIcIbSQiTRXOsbLiuJfgNQ==", + "dev": true, + "requires": { + "@babel/template": "7" + } + }, "babel-plugin-transform-strict-mode": { "version": "6.24.1", "resolved": "https://registry.npmjs.org/babel-plugin-transform-strict-mode/-/babel-plugin-transform-strict-mode-6.24.1.tgz", diff --git a/package.json b/package.json index 0f4c00ded2..f9dd1cc3ae 100644 --- a/package.json +++ b/package.json @@ -44,6 +44,7 @@ "@vue/eslint-config-prettier": "5.0.0", "@vue/test-utils": "1.1.0", "babel-eslint": "10.1.0", + "babel-plugin-transform-require-context": "0.1.1", "check-node-version": "4.0.3", "compression-webpack-plugin": "6.0.3", "eslint": "7.11.0", diff --git a/tests/unit/AppHeader.spec.js b/tests/unit/AppHeader.spec.js index f9a653955e..6d359c88a4 100644 --- a/tests/unit/AppHeader.spec.js +++ b/tests/unit/AppHeader.spec.js @@ -12,6 +12,7 @@ describe('AppHeader.vue', () => { const actions = { 'global/getHostStatus': jest.fn(), 'eventLog/getEventLogData': jest.fn(), + 'authentication/resetStoreState': jest.fn(), }; const store = new Vuex.Store({ actions }); diff --git a/tests/unit/__snapshots__/AppHeader.spec.js.snap b/tests/unit/__snapshots__/AppHeader.spec.js.snap index 712353b0c8..8300ac1900 100644 --- a/tests/unit/__snapshots__/AppHeader.spec.js.snap +++ b/tests/unit/__snapshots__/AppHeader.spec.js.snap @@ -23,30 +23,33 @@ exports[`AppHeader.vue should render correctly 1`] = ` aria-hidden="true" class="nav-trigger" id="app-header-trigger" - title="Open navigation" type="button" variant="link" > - @@ -55,7 +58,7 @@ exports[`AppHeader.vue should render correctly 1`] = ` class="header-logo" src="@/assets/images/logo-header.svg" /> - + + + + + + + + + + + - + + + `; @@ -540,19 +588,19 @@ exports[`AppNavigation.vue should render with nav-container open 1`] = ` > @@ -572,16 +620,16 @@ exports[`AppNavigation.vue should render with nav-container open 1`] = ` > @@ -608,68 +656,79 @@ exports[`AppNavigation.vue should render with nav-container open 1`] = ` - + + + + + + + + + + - + + + `;