Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Compiled pytorch within MOOSE-dev container. #29690

Draft
wants to merge 5 commits into
base: next
Choose a base branch
from
Draft

[WIP] Compiled pytorch within MOOSE-dev container. #29690

wants to merge 5 commits into from

Conversation

grmnptr
Copy link
Contributor

@grmnptr grmnptr commented Jan 14, 2025

Closes #29661

loganharbour
loganharbour requested changes Jan 14, 2025
View reviewed changes
apptainer/moose-dev.def
@@ -81,7 +81,8 @@ Fingerprints: 0CFFCAB55E806363601C442D211817B01E0911DB

# Pinned versions
MINIFORGE_VERSION=23.3.1-1
PYTHON_VERSION=3.11
PYTHON_VERSION={{ MOOSE_PYTHON_VERSION }}
echo $PYTHON_VERSION
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
echo $PYTHON_VERSION

apptainer/moose-dev.def
export CXXFLAGS+=" -Wno-error=maybe-uninitialized -Wno-error=uninitialized -Wno-error=restrict"

# Build and install
export CMAKE_PREFIX_PATH="${CONDA_PREFIX:-'$(dirname $(which conda))/../'}:${CMAKE_PREFIX_PATH}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing something like this directly into CONDA_PREFIX isn't great, because conda doesn't know about it. Is this what they suggest you do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah these are the official instructions. So you are suggesting installing this somewhere else and adding it to python path?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loganharbour loganharbour loganharbour requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add natively compiled torch to doose-dev container.
2 participants
@grmnptr @loganharbour