Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update existing helpers for new Canvas types #177

Open
digitaldogsbody opened this issue Mar 10, 2023 · 0 comments
Open

Update existing helpers for new Canvas types #177

digitaldogsbody opened this issue Mar 10, 2023 · 0 comments
Labels
discuss For discussion in next catchup meeting enhancement New feature or request helper Helper method to be added

Comments

@digitaldogsbody
Copy link
Member

Something that occurred to me when doing the work in #176 - we now have PlaceholderCanvas and AccompanyingCanvas and they can make use of all(?) the helpers that are applicable to Canvas objects and so we should look at updating existing helpers to monkeypatch them in here when appropriate.

Additionally, we might consider extending make_canvas_from_iiif to be able to create either of the other types.

  1. By passing object type in the constructor - slight clunky, breaking change
  2. By copying the existing code into a new helper and changing the object type created - less work, but violates DRY
  3. By wrapping the existing function and type-coercing - unsure if this would work, but it's my favoured approach if it does
@digitaldogsbody digitaldogsbody added enhancement New feature or request helper Helper method to be added discuss For discussion in next catchup meeting labels Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss For discussion in next catchup meeting enhancement New feature or request helper Helper method to be added
Projects
None yet
Development

No branches or pull requests

1 participant