Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up mentions and discussions of devicemotion #332

Closed
blairmacintyre opened this issue Mar 13, 2018 · 10 comments · Fixed by #334
Closed

clean up mentions and discussions of devicemotion #332

blairmacintyre opened this issue Mar 13, 2018 · 10 comments · Fixed by #334

Comments

@blairmacintyre
Copy link
Contributor

There are a number of discussions of devicemotion in the documents. The API was never standardized, and multiple organizations are pushing to change or remove it. So, for example, we should not assume a developer can use device motion before or instead of creating a session, and may want to be explicit in ensuring that WebXR handles all the use cases it needs to without assuming devicemotion exists.

@toji
Copy link
Member

toji commented Mar 14, 2018

Which documents do you see devicemotion mentioned in? I did some searches and turned up nothing.

@blairmacintyre
Copy link
Contributor Author

Sorry: deviceorientation.

@toji
Copy link
Member

toji commented Mar 14, 2018

Ah, got it. FWIW the bulk of references to the API are in the "Why not use thing X instead of a new API?" section of the explainer. As a result I would suggest that the appropriate step to take it to add a line to that section about how the API is non-standard and being pushed for removal, since that seems like a good reason not to use it. 😁 I'll scrub references to it from the rest of the doc, though.

@toji
Copy link
Member

toji commented Mar 14, 2018

Also, do you have any links handy that demonstrate the effort to change or remove the API? It would be good to point to them in the explainer in the "why not" section.

@blairmacintyre
Copy link
Contributor Author

Looks good.

@anssiko
Copy link
Contributor

anssiko commented Mar 14, 2018

The new API: https://w3c.github.io/orientation-sensor/

@cvan
Copy link
Contributor

cvan commented Mar 15, 2018

btw, there's a ton of context and good discussion about the Generic Sensor APIs here when support was recently added to the WebVR Polyfill: immersive-web/cardboard-vr-display#10

(note: cardboard-vr-display is an npm package dependency of webvr-polyfill)

@anssiko
Copy link
Contributor

anssiko commented Mar 19, 2018

Now that webvr-polyfill recommends users to enable Generic Sensor APIs (see https://github.com/immersive-web/webvr-polyfill/releases/tag/v0.10.3) it is probably a good idea to acknowledge them in the Explainer in place of the legacy deviceorientation/devicemotion API.

Any concerns? I can craft a PR.

@toji
Copy link
Member

toji commented Mar 20, 2018

No concerns here. Given that you seem more familiar with the Generic Sensor APIs than I am I'd appreciate it if you could put together a PR, thanks!

@anssiko
Copy link
Contributor

anssiko commented Mar 21, 2018

@toji, see PR #334.

@toji toji closed this as completed in #334 Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants