-
Notifications
You must be signed in to change notification settings - Fork 3
Code Reviews
Pablo Villar edited this page Sep 27, 2016
·
11 revisions
Code reviews are fundamental to software development. Each piece of code should never be introduced in a master branch without previous approval from another member of the team.
Here is a list of rules and suggestions to follow:
#Rules #####Mandatory: If a rule is not followed, the pull request should be rejected.
- Swift API Design Guidelines — Must be followed
- Code Syntax — Enforced by linter tool
- Access Control
- Acronyms Capitalization
- IBAction Functions
- NotificationCenter Functions
- Optionals
- Variables Capitalization
#Suggestions #####Optional: Suggestions must be considered when writing code, but do not cause a pull request rejection.