Type Error & unhandled promise rejection error when navigating dashboards in cloud2

[philjb]

About the bug

While editing a dashboard, I received the "an error has occurred. please report here" message so I am reporting it here.

The error seemed to be persistent as I navigated around (see the gifs) but I'm not sure how to reproduce it.

In the zip archive are two text files showing the console errors. Here's the top of them.

==> error1 <==
[Error] TypeError: Type error
decode
D — flux-lsp-browser_bg.js:342
__wbindgen_json_parse — bootstrap:69
wasm-stub
<?>.wasm-function[4200]
<?>.wasm-function[1895]
wasm-stub
C — flux-lsp-browser_bg.js:225
s — astim.ts:22

==> error2 <==
[Error] Unhandled Promise Rejection: SyntaxError: JSON Parse error: Unrecognized token ''
        parse (30.f5990f947f.js:2:1779771)
        D (30.f5990f947f.js:2:1779771)
        __wbindgen_json_parse (c0375f819e.js:1:544)
        wasm-stub
        <?>.wasm-function[4200]
        <?>.wasm-function[1895]
        wasm-stub
        C (30.f5990f947f.js:2:1779085)
        s (31.9bc96f602e.js:1:642599)

Steps to reproduce:
List the minimal actions needed to reproduce the behavior.

Unknown

Expected behavior:
Use cloud2 without errors.

Actual behavior:
Page crashed and reported than an error has occurred.

Visual Proof:

Archive.zip

About your environment

Environment info:
cloud2

Config:

na

Logs:

see archive above for console log
Performance:
na

[philjb]

I got two type errors when just scrolling down my dashboard

==> type error <==
[Error] Unhandled Promise Rejection: TypeError: Type error
        decode (30.19444cc24f.js:2:1779773)
        D (30.19444cc24f.js:2:1779773)
        __wbindgen_json_parse (fc7b1f118e.js:1:544)
        wasm-stub
        <?>.wasm-function[4200]
        <?>.wasm-function[1895]
        wasm-stub
        C (30.19444cc24f.js:2:1779085)
        s (31.5d780fd62b.js:1:643541)

==> type error2 <==
[Error] TypeError: Type error
decode
D — flux-lsp-browser_bg.js:342
__wbindgen_json_parse — bootstrap:69
wasm-stub
<?>.wasm-function[4200]
<?>.wasm-function[1895]
wasm-stub
1895
C — flux-lsp-browser_bg.js:225

Archive.zip

[philjb]

@rockstar - this might be a lsp issue based on the referenced file? flux-lsp-browser_bg.js:342

[abalone23]

I just got this error as well. Console shows:

Unhandled Promise Rejection: Error: Model is disposed!

Complete console log:
console_mon.log

[rockstar]

Just a spitball here, but @wiedld recently changed the way the ui communicates with the lsp, and I'm willing to bet it's blindly calling JSON.parse on whatever is returned from the lsp. However, in some cases, e.g. textDocument/didOpen, there is no response body, so it's essentially doing JSON.parse('') and blowing up. We had this issue in the ui when we went to using lspower because the previous protocol implementation was incorrectly sending a valid json body in response.

[wiedld]

blindly calling JSON.parse on whatever is returned from the lsp.

All responses from the LSP are wrapped in error handling, on the JSON.parse(). It only transmits a response back to the monaco-editor if the response can be parsed.

[wiedld]

Recreated the likely error in the use cases shown by @philjb , and have a solution in progress. However, those use cases did not use the raw flux script editor. Therefore the stacktrace shown by @abalone23 does not apply.

Could you please give me a rundown @abalone23 of exactly the path you took to hit that console error? Thanks!

[abalone23]

@wiedld I was probably writing Flux in Data Explorer Script Editor.

[wiedld]

One fix merged.
Changing status back to "in progress", and will consider Adam2's use case next week.

[wiedld]

Reviewed again the error @abalone23 found. Could not recreate; could only hypothetically see how it may occur.
Added error logging/metrics to measure frequency and [hopefully] isolate cause of this error.