Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

184 feature request add teal app showcasing tealmodulesbsafe #186

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

184 feature request add teal app showcasing tealmodulesbsafe #186

wants to merge 2 commits into from

Conversation

Xyarz
Copy link
Collaborator

@Xyarz Xyarz commented Jan 21, 2025

Added the bsafe app as discussed with Dony. Had to adjust some minor parts as we don't have images for the application yet.

@Xyarz Xyarz linked an issue Jan 21, 2025 that may be closed by this pull request
[Feature Request]: add teal app showcasing teal.modules.bsafe #184
Open
3 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025 •
edited
Loading

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@Xyarz
Copy link
Collaborator Author

Xyarz commented Jan 21, 2025

I have read the CLA Document and I hereby sign the CLA

@Xyarz Xyarz requested a review from donyunardi January 21, 2025 07:20
@vedhav
Copy link
Contributor

vedhav commented Jan 21, 2025

Thank you for the PR @Xyarz
When I tried to run this app I was unsuccessful. I am using the teal and related packages from the main branch, you can easily install them by getting them from pharmaverse r-universe. I think the package needs some updates to use the latest version of teal.

Can you please raise another PR by taking a branch from the dev instead of the main branch. Because, this app cannot be merged to the main branch without the CRAN release of bsafe and teal.modules.bsafe.
Both these branches are detached from each other so we do a manual merge of dev into main after a release cycle of the packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donyunardi donyunardi Awaiting requested review from donyunardi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: add teal app showcasing teal.modules.bsafe
2 participants
@Xyarz @vedhav