Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question]: Should decorators be also tested at the modules packages level? #1454

Open
m7pr opened this issue Jan 20, 2025 · 1 comment
Open
Labels
core question Further information is requested

Comments

@m7pr
Copy link
Contributor

m7pr commented Jan 20, 2025

What is your question?

Currently there are 3 tests in teal and 2 shinytest2 tests in teal that cover decorators. Even though the main functionality is implemented in teal, actual usage and some customization is provided at modules packages. Should we extend modules packages tests (like in tmg/tmc) to cover decorators usage? Those module packages have some custom functions for decorators specification that do not exist in teal, hence the reason to test them there.

Some examples to be used for tmg:

@m7pr m7pr added core question Further information is requested labels Jan 20, 2025
@gogonzo
Copy link
Contributor

gogonzo commented Jan 20, 2025

Decorators should be tested in teal.modules.*. teal doesn't execute decorators as they are included through ui_args and server_args. teal can't guarantee if decorator returns correct object - it is impossible unless we introduce the design in which decorator would check itself (is it possible?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants