Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jinja templating should be off unless a context is provided. #1288

Open
spott opened this issue Dec 31, 2024 · 0 comments
Open

Jinja templating should be off unless a context is provided. #1288

spott opened this issue Dec 31, 2024 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@spott
Copy link

spott commented Dec 31, 2024

Is your feature request related to a problem? Please describe.
I'm passing raw markdown into the prompt, I didn't expect that markdown to be parsed by jinja because I'm not using that feature.

I wasn't aware of it until I ran into a jinja templating error because the markdown I was running had jinja template parameters in it.

Describe the solution you'd like
If there is no context dictionary passed, then there isn't any need to look for jinja template information.

If they want to pass a Jinja template but don't need any context, they can pass an empty dict.

This just makes it so that the user isn't using the feature unless they opt in.

Describe alternatives you've considered
The other option is sanitizing the input for jinja template parameters... or explicitly passing input as a trivial jinja template ({{input}}), which is kinda annoying.

@github-actions github-actions bot added bug Something isn't working enhancement New feature or request labels Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant