Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc for building LLVM Target #409

Closed
Stonepia opened this issue Jan 31, 2024 · 4 comments · Fixed by #420 or #421
Closed

Doc for building LLVM Target #409

Stonepia opened this issue Jan 31, 2024 · 4 comments · Fixed by #420 or #421
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@Stonepia
Copy link
Contributor

Stonepia commented Jan 31, 2024

Hello, Could you help to provide a doc for building the LLVM target?

I notice that you have offered a compile-triton.sh, but could you write a formal doc describing that? About how to build the triton, and how to run a basic kernel for checking.

In addition, I have two thoughts about this file:

  1. What is the recommended BASE env setting? From the script, the default setting is BASE=/iusers/$USER , and it should be the parent folder of the triton folder. Normally, there is no iusers folder, so I would suggest that this iuser be changed to something like $HOME/....
  2. The cmake is hardcoded to /usr/bin/cmake, but there are cases when the user wants to use cmake in conda env, especially when the user doesn't have root permission to install cmake in the system path.
@Stonepia Stonepia changed the title BKC for building LLVM Target Doc for building LLVM Target Jan 31, 2024
@kurapov-peter kurapov-peter added the documentation Improvements or additions to documentation label Jan 31, 2024
@etiotto
Copy link
Contributor

etiotto commented Jan 31, 2024

  1. What is the recommended BASE env setting? From the script, the default setting is BASE=/iusers/$USER , and it should be the parent folder of the triton folder. Normally, there is no iusers folder, so I would suggest that this iuser be changed to something like $HOME/....
  2. The cmake is hardcoded to /usr/bin/cmake, but there are cases when the user wants to use cmake in conda env, especially when the user doesn't have root permission to install cmake in the system path.

Correct it is the parent of the project folder. We can change the script to use $HOME (or ../../) and also avoid hardcoding the location of the cmake executable.

@whitneywhtsang
Copy link
Contributor

Hi @Stonepia , thanks for your suggestions, PRs are created to address them.

how to run a basic kernel for checking

For checking, we use test-triton.sh. It takes option to run different kind of tests, e.g., -lit, -core, -tutorial, etc.

@chsasank kindly offered to help in documenting the build process. (#335 (comment))
Can we track that effect in #327?

If you have any questions on building or testing in the meantime, we are happy to help.

@whitneywhtsang
Copy link
Contributor

Issue was closed automatically when the PRs were merged in. Reopening to give @Stonepia a chance to response.

@Stonepia
Copy link
Contributor Author

Stonepia commented Feb 2, 2024

thanks for the help! Issue could be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
5 participants