Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCRE library - to maintainer version #26

Open
leyao-daily opened this issue Jul 18, 2022 · 3 comments
Open

PCRE library - to maintainer version #26

leyao-daily opened this issue Jul 18, 2022 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@leyao-daily
Copy link

There are two major versions of the PCRE library. The current version, PCRE2, released in 2015, is now at version 10.39.

The older, but still widely deployed PCRE library, originally released in 1997, is at version 8.45. This version of PCRE is now at end of life, and is no longer being actively maintained. Version 8.45 is expected to be the final release of the older PCRE library, and new projects should use PCRE2 instead.

I think it can be easily compiled to wasm library based on https://github.com/leyao-daily/pcre2 and we may modify ModSecurity configuration to accept this update.

@leyao-daily leyao-daily added the help wanted Extra attention is needed label Jul 18, 2022
@M4tteoP
Copy link
Contributor

M4tteoP commented Jul 18, 2022

Based on this comment, PCRE is still a needed dependency even if we enable PCRE2. So, to make it work, I think we have to build pcre2 and provide it to modsec with a proper configuration on top of what we already have. I would suggest doing tries on top of #24, just because of the updated emsdk (if we feel that that PR is going to be okay).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants
@jcchavezs @M4tteoP @leyao-daily and others