Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to merge queue for librarians (like we have for super librarians) #10293

Open
RayBB opened this issue Jan 7, 2025 · 15 comments · May be fixed by #10327
Open

Add link to merge queue for librarians (like we have for super librarians) #10293

RayBB opened this issue Jan 7, 2025 · 15 comments · May be fixed by #10327
Assignees
Labels
Affects: Librarians Issues related to features that librarians particularly need. [managed] Good First Issue Easy issue. Good for newcomers. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@RayBB
Copy link
Collaborator

RayBB commented Jan 7, 2025

Proposal

Right now super librarians can see a button for merge queue in the menu. It's quite handy.
I propose we make the button visible for librarians too. Otherwise it's not easy to get to the merge queue to see how your merge requests are progressing.

What super librarians see:
image
What regular librarians see:
image

Justification

Breakdown

Requirements Checklist

  • [ ]

Related files

Stakeholders


Instructions for Contributors

Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.

@RayBB RayBB added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Good First Issue Easy issue. Good for newcomers. [managed] Affects: Librarians Issues related to features that librarians particularly need. [managed] Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] labels Jan 7, 2025
@ananyakaligal

This comment was marked as outdated.

@RayBB

This comment was marked as outdated.

@AST0008
Copy link

AST0008 commented Jan 7, 2025

@RayBB hey, can i work on this?

@RayBB
Copy link
Collaborator Author

RayBB commented Jan 7, 2025

@AST0008 yes. Please be sure to read the contributing guide and add screenshots to your PR.

@PredictiveManish
Copy link

If I worked on this can I open a PR?

@RayBB
Copy link
Collaborator Author

RayBB commented Jan 10, 2025

@AST0008 are you still working on this?
If we don't hear back from AST0008 by Monday then you can open your PR @PredictiveManish

@PredictiveManish
Copy link

@AST0008 are you still working on this? If we don't hear back from AST0008 by Monday then you can open your PR @PredictiveManish

Sure.

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Jan 11, 2025
@ananyakaligal
Copy link
Contributor

@AST0008 are you still working on this?

@AST0008
Copy link

AST0008 commented Jan 12, 2025

@ananyakaligal you can work on this, I'm currently busy with something else

@RayBB RayBB assigned PredictiveManish and unassigned AST0008 Jan 12, 2025
@RayBB
Copy link
Collaborator Author

RayBB commented Jan 12, 2025

@PredictiveManish I assigned you since you asked first. Then @ananyakaligal is next in line :)
Thanks for keeping us updated @AST0008

@mekarpeles
Copy link
Member

mekarpeles commented Jan 13, 2025

@PredictiveManish

Before you go too deep into trying to solve the issue, can you please first help us with breakdown by:

  1. Clarifying what you believe the task to be
  2. Identifying which files you believe may be related from the project
  • as a freebie, I did a search for "Pending Merge Requests" -- the item we want to show up for more patrons -- and found this match:
    $ loginLinks.insert(2, { "href": homepath() + "/merges", "text": _("Pending Merge Requests"),"track": "MyRequests", "badge": True })
  1. Asking any question(s) you may have about the goal or requirements of this issue
  2. Proposing a solution or approach

Thank you for your help!

@mekarpeles mekarpeles removed the Needs: Response Issues which require feedback from lead label Jan 13, 2025
@andycandy
Copy link

I'd love to work on this issue if its okay.

@PredictiveManish
Copy link

@PredictiveManish I assigned you since you asked first. Then @ananyakaligal is next in line :) Thanks for keeping us updated @AST0008

Thanks for giving me opportunity to work.

@PredictiveManish
Copy link

PredictiveManish commented Jan 13, 2025

Here the librarians can also be allowed and a simple UI Change might be solving this issue completely.
For solving this issue:
This two files can be changed a little bit to allow librarians to see the pending merge requests option and also they can be able to merge from their side.
First here the librarian can be added to showing pending merge requests button:

$ is_privileged_user = ctx.user and (ctx.user.is_admin() or ctx.user.is_super_librarian())

Then the logic of allowing library will help to overcome the issue with using this file.
Also,

:

like here it is allowed for superlibrarians similar can be done for librarians too.

@RayBB
Copy link
Collaborator Author

RayBB commented Jan 13, 2025

@PredictiveManish Only the first change is needed. Add is_librarian and that should be good to go!

The second one is for the actual merges instead of seeing the merge queue.

Please open a PR for this.

@PredictiveManish PredictiveManish linked a pull request Jan 13, 2025 that will close this issue
@RayBB RayBB moved this to Addressed in another card (pr/issue) in Ray's Project Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Librarians Issues related to features that librarians particularly need. [managed] Good First Issue Easy issue. Good for newcomers. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
Status: Addressed in another card (pr/issue)
Development

Successfully merging a pull request may close this issue.

6 participants