-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to merge queue for librarians (like we have for super librarians) #10293
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@RayBB hey, can i work on this? |
@AST0008 yes. Please be sure to read the contributing guide and add screenshots to your PR. |
If I worked on this can I open a PR? |
@AST0008 are you still working on this? |
Sure. |
@AST0008 are you still working on this? |
@ananyakaligal you can work on this, I'm currently busy with something else |
@PredictiveManish I assigned you since you asked first. Then @ananyakaligal is next in line :) |
Before you go too deep into trying to solve the issue, can you please first help us with breakdown by:
Thank you for your help! |
I'd love to work on this issue if its okay. |
Thanks for giving me opportunity to work. |
Here the librarians can also be allowed and a simple UI Change might be solving this issue completely.
Then the logic of allowing library will help to overcome the issue with using this file.
like here it is allowed for superlibrarians similar can be done for librarians too. |
@PredictiveManish Only the first change is needed. Add is_librarian and that should be good to go! The second one is for the actual merges instead of seeing the merge queue. Please open a PR for this. |
Proposal
Right now super librarians can see a button for merge queue in the menu. It's quite handy.
I propose we make the button visible for librarians too. Otherwise it's not easy to get to the merge queue to see how your merge requests are progressing.
What super librarians see:
What regular librarians see:
Justification
Breakdown
Requirements Checklist
Related files
Stakeholders
Instructions for Contributors
Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
The text was updated successfully, but these errors were encountered: