Editing a book fails when malformed table of contents data is submitted

[jimchamp]

Problem

Using the book edit UI, patrons can add table of contents data to an edition. When this data is formatted properly, a rich table of contents will be displayed on the edition's page.

Unfortunately, if the data is malformed such that it cannot be parsed, the edit operation fails and the patron is shown an unhelpful error page:

Here is an example of a malformed table of contents entry:

* | Forward | 1
    ** 1 | | A new chapter | 12

Example well-formed table of contents

* | Forward | 1 ** 1 | A new chapter | 12

Removing the second | character from line two corrected the malformed entry.

Reproducing the bug

Using you local development environment:

1. Go to an edition page and click the "Edit" button to open the edit UI.
2. Ensure that you click the edition tab (found to the right of the "Work Details" tab.
3. Paste the malformed table of contents data into the table of contents field.
4. Submit the form.

• Expected behavior: You are taken back to the edition page. There is a flash message thanking you for updating the record. The table of contents can now be seen in the details section of the page.
• Actual behavior: An error page is displayed.

Context

• Browser (Chrome, Safari, Firefox, etc): Any
• OS (Windows, Mac, etc): All
• Logged in (Y/N): Y
• Environment (prod, dev, local): prod

Breakdown

Requirements Checklist

• [ ]

Related files

Stakeholders

---

Instructions for Contributors

• Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.

[mekarpeles]

/openlibrary/openlibrary/plugins/upstream/table_of_contents.py in from_markdown

L 133        return TocEntry( 

/openlibrary/openlibrary/plugins/upstream/table_of_contents.py in from_markdown

L 48                TocEntry.from_markdown(line)