Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a list of work titles that will avoid conflation on edition title mismatch #10342

Open
cdrini opened this issue Jan 16, 2025 · 1 comment
Labels
Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@cdrini
Copy link
Collaborator

cdrini commented Jan 16, 2025

Proposal

There are certain cases of works which we want to exclude imported editions/works from joining. For example:

  • Generic titles like "Bill" / "Law" ( although I'm not sure we import these anymore )
  • Certain series names, like "The Diary of a Wimpy Kid"
  • Certain biographical books like "Picasso"

(links welcome please, was having trouble finding the exact examples I've seen in the past)

There aren't a ton of works in this category ; and although having a more systemic solution to the problem would be ideal, perhaps having a temporary solution that's just a list that makes the resolution process for these works more strict will be a boon.

We noticed while investigating some old code in #10336 (comment) that there was a code path there that tried to do something like this, but which due to a logic bug never actually did anything at all. The idea behind it is sound/useful though.

Justification

Breakdown

Requirements Checklist

  • [ ]

Related files

Stakeholders


Instructions for Contributors

Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.

@cdrini cdrini added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Jan 16, 2025
@seabelis
Copy link
Collaborator

seabelis commented Jan 18, 2025

Generally there are problems with titles containing the words "works", "novels", "stories", "plays", "poems", "selected", and "selections". These are frequently collected works where the collections vary. Editor names are important in these cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Development

No branches or pull requests

2 participants