Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISBNs rendered as phone numbers in Safari #10364

Open
zorae opened this issue Jan 19, 2025 · 2 comments
Open

ISBNs rendered as phone numbers in Safari #10364

zorae opened this issue Jan 19, 2025 · 2 comments
Labels
Good First Issue Easy issue. Good for newcomers. [managed] Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Needs: Response Issues which require feedback from lead Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Type: Bug Something isn't working. [managed]

Comments

@zorae
Copy link

zorae commented Jan 19, 2025

Problem

By default, Safari on iOS detects any string formatted like a phone number and makes it a link that calls the number. This affects ISBN-10, possibly also other ID numbers.

Image

To disable phone number recognition, we should add <meta name="format-detection" content="telephone=no">.

Source: Apple’s documentation

Reproducing the bug

No response

Context

  • Browser (Chrome, Safari, Firefox, etc): Safari
  • OS (Windows, Mac, etc): iPadOS 18.3
  • Logged in (Y/N): Y
  • Environment (prod, dev, local): prod

Breakdown

Requirements Checklist

  • [ ]

Related files

Stakeholders

Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@zorae zorae added Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed] labels Jan 19, 2025
@mekarpeles mekarpeles added Good First Issue Easy issue. Good for newcomers. [managed] Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] and removed Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Jan 19, 2025
@Lokeshranjan8
Copy link

can i work on this issue? @zorae

@PredictiveManish
Copy link

Want to work on this issue.

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Easy issue. Good for newcomers. [managed] Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Needs: Response Issues which require feedback from lead Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mekarpeles @zorae @PredictiveManish @Lokeshranjan8