-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Richer UI install for PWA on Chrome #8929
Comments
Hi, @RayBB I'd like to work on that |
@Sameer-Pal that would be wonderful! |
@Sameer-Pal please let me know if you're still working on this. Otherwise we can give someone else a chance to work on it. |
Hi, @RayBB |
Hi, @RayBB It's been written to clone using SSH not using HTTPS but it's not working that way! |
@Sameer-Pal, it may be the case that you need to add your SSH key to GitHub. If you've not tried the steps in Permission denied while cloning, they may be worth checking out. |
@Sameer-Pal, did you mean to remove your assignment from this issue or are you still working on a PR? I might be interested in taking this over if you are looking to hand it off. |
@OfcPeriwinkle please go ahead and try. You're assigned now. |
Just wanted to post an update since it's been a little bit. I submitted a volunteer form a few days ago and I'm just waiting on the Slack invite. I have a draft description and some screenshots for review once I'm able to join the channel. I tested out the manifest locally with the desktop screenshots I have and everything looks like what we'd expect. I'm not too sure how to go about testing the mobile install UI locally so if someone has an idea of how to do that I'm all ears! |
@mekarpeles can you check the volunteer form? |
@OfcPeriwinkle are you still working on this? |
@RayBB Just started a new job so I've been busy with onboarding. I'll post what I have for review once I get some time this week. |
@OfcPeriwinkle I think these look pretty fantastic. I'm going to see if we can get any community feedback. Thanks! |
@mekarpeles @cdrini do either of you wanna provide feedback this? |
Taking a look at this now; those look great @OfcPeriwinkle ! We have a similar set of screenshots we use for the play store here: https://github.com/internetarchive/openlibrary/blob/59c8fa5ce588020633ee0f16d23aa052d8a43ea9/conf/twa/Play_Store_SS.mockup . It has screenshots for a few of the places you have taken screenshots, but they're a bit outdated. Would you be able to update the .mockup file with screenshots for the current site? And use the same format to create new screenshots for desktop. For the description, let's copy it from the play store to be consistent: Open Library is an open, editable library catalog, building towards a web page for every book ever published. Read, borrow, and discover more than 3M books for free. |
@OfcPeriwinkle I unassigned you as we haven't heard back in a while. Please let me know if you decide to work on it again. |
Hello, I would like to be assigned to this issue and try to solve it! |
@DachiCharkviani you're assigned. Good luck! |
@ananyakaligal could you work on this one? |
@RayBB Definitely |
@ananyakaligal assigned :) |
Shall I proceed with the screenshots discussed earlier in this conversation? I've cross-checked them to ensure they're not outdated. However, the screenshot for the search books page needs to be updated since the design of the search navigation bar has changed. Everything else looks good. |
Yes let's proceed
…On Mon, Jan 27, 2025, 1:52 PM Ananya Sriramareddy Kaligal < ***@***.***> wrote:
@RayBB <https://github.com/RayBB>,
Shall I proceed with the screenshots discussed earlier in this
conversation? I've cross-checked them to ensure they're not outdated.
However, the screenshot for the search books page needs to be updated since
the design of the search navigation bar has changed. Everything else looks
good.
—
Reply to this email directly, view it on GitHub
<#8929 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHA5AL4GQFKTGGFGBT5Z3T2MZ56LAVCNFSM6AAAAABE7YRLTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJWGYZTENRQHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@RayBB Do I upload the desktop screenshots as well to the same 'screenshots' folder in .mockup or create a new folder for it? |
You can make a new folder.
…On Mon, Jan 27, 2025, 3:44 PM Ananya Sriramareddy Kaligal < ***@***.***> wrote:
@RayBB <https://github.com/RayBB> Do I upload the desktop screenshots as
well to the same 'screenshots' folder in .mockup or create a new folder for
it?
—
Reply to this email directly, view it on GitHub
<#8929 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHA5AJBPXKZOPUKDNH3HJD2M2LBXAVCNFSM6AAAAABE7YRLTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJWHA2TCOBVGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Chrome supports a richer install UI for progressive web apps.
We can include screenshots (both mobile and desktop) and a description.
Img of how it looks
Describe the problem that you'd like solved
Use these new features to improve the experience.
Proposal & Constraints
Your task:
Note: this is not compatible with Firefox
If you would like to work on this please just say you'd like to work on it and get started. I'll assign it to you when I get a chance.
Additional context
Stakeholders
The text was updated successfully, but these errors were encountered: