Comparison with other types #19
Conversation
kaplun
force-pushed
the
18-comparison-with-other-types
branch
from
7430b6a to
3d95c35
Compare
|
Note @dset0x, this branch does not fully mimic the behavior of |
* Comparing an intbitset with anything that is not an intbitset should behave as a set would. E.g. intbitset([1,2,3]) == set([1,2,3]) is False. (closes inveniosoftware-contrib#18) Signed-off-by: Samuele Kaplun <[email protected]> Reported-by: Dimitrios Semitsoglou-Tsiapos <[email protected]>
kaplun
force-pushed
the
18-comparison-with-other-types
branch
from
3d95c35 to
3fb6d9b
Compare
|
I will be reviewing and may be rebasing and merging this at last! |
|
Four years sure fly by quickly. |
|
Closing PR as it's stale for several years. |
|
@lnielsen the code is stable and this PR is still valid... so let me review and merge. It is LTGM otherwise. |
|
Actually this is not readily mergeable... my bad. Closing indeed. |
|
I was really counting on this one. (´д｀) |
|
Just FYI, I was doing cleanup of old pull requests in inveniosoftware organisation, that was the main reason to close it since it was open since 2014 :-) |
|
@dset0x we can implement it still... but the code in this PR was stale and not exactly working as expected. |
should behave as a set would. E.g.
intbitset([1,2,3]) == set([1,2,3]) is False.
(closes Support comparisons with other types. #18)
Signed-off-by: Samuele Kaplun [email protected]
Reported-by: Dimitrios Semitsoglou-Tsiapos [email protected]