Accounts still banned without intercation

[sebix]

As we just expierenced, the automatic scheduled unlocking does not work.

The configured date was 28.11.2024 00:00:00. Yet the user account was still locked to this day. Unlocked the account now manually.

[chris34]

I think there is a misconception here: The user will be automatically unbanned on login, if the banning period is over. If the user does no try to login again, the status will still be banned in the database.

At the moment there is no background task (e.g. via celery) to change the users status.

For reference:

• https://github.com/inyokaproject/inyoka/blob/staging/inyoka/portal/auth.py#L45-L47 the unban logic is triggered via the authentication backend
• https://github.com/inyokaproject/inyoka/blob/staging/inyoka/portal/user.py#L494-L499

To be honest it did not find a test for it, but i just quickly checked it manually. And the user was unbanned on login.

Do we know if the user tried to login (e.g. if he explicitly wrote it to use)? Otherwise, I would this consider more an enhancement for a background task to unban, than a bug.

[sebix]

Thank you for the explanation, that makes sense.

So, yes, this could be an enhancement, not a bug.