Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnhandledPromiseRejectionWarning on error #45

Open
ZJONSSON opened this issue Feb 2, 2018 · 6 comments · May be fixed by #46
Open

UnhandledPromiseRejectionWarning on error #45

ZJONSSON opened this issue Feb 2, 2018 · 6 comments · May be fixed by #46

Comments

@ZJONSSON
Copy link
Contributor

ZJONSSON commented Feb 2, 2018

If an error occurs in the ParquetTransformer._transform the stream is left in limbo state. Node logs out the following warning:

(node:10265) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): invalid value for INT64: N/A
(node:10265) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
@ZJONSSON ZJONSSON linked a pull request Feb 2, 2018 that will close this issue
Open
@burgrp
Copy link

burgrp commented Jul 17, 2019

Just found unhandled promise rejection in ParquetTransformer, line 268:

  _transform(row, encoding, callback) {
    if (row) {
      this.writer.appendRow(row).then(callback);
    } else {
      callback();
    }
  }

@ZJONSSON
Copy link
Contributor Author

@burgrp you will also find the proposed fix in the reference above, from Feb 1 2018

@burgrp
Copy link

burgrp commented Jul 18, 2019

Thanks @ZJONSSON . It's a pity, it's not merged yet.

@ed-sparkes
Copy link

Any chance of getting this fix merged and new version published ?

@emranuddin75
Copy link

Its a useful change to merge in, and would be very much appreciated to capture the rejection rather than silently dying.
Let me now when that would likely to be merged so that i can harden the code.

@sambonbonne
Copy link

Does anyone have a workaround to handle promise rejection?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

If there is an error in transform -> pass error to callback ZJONSSON/parquetjs
5 participants
@ed-sparkes @ZJONSSON @sambonbonne @burgrp @emranuddin75