Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage native dialog element for Modal #347

Open
daneah opened this issue May 18, 2022 · 1 comment · May be fixed by #851
Open

Leverage native dialog element for Modal #347

daneah opened this issue May 18, 2022 · 1 comment · May be fixed by #851

Comments

@daneah
Copy link
Member

daneah commented May 18, 2022

The problem

Modals present a number of accessibility challenges to get right, including:

  • Focus trapping in the dialog itself
  • Making the background content inert
  • Announcing the dialog to screen readers

The solution

The native dialog element handles many of these challenges natively, reducing the code we need to manage ourselves. As the dialog and standards around it evolve, we won't need to react as often/deeply.

Additional information

This has wide support, but Safari only supports it as of 15.4—we'll need to wait just a bit until we no longer need to support older Safari versions.

@daneah
Copy link
Member Author

daneah commented Aug 30, 2024

Browser support has been fairly full for ~2 years now, so I suspect we are in a place to investigate making this move.

@daneah daneah linked a pull request Jan 26, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant