-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GLOBALS/TEMPLATE vs TABLE_MAPPING/TABLE_RAW_TEMPLATE #9
Comments
The question is to know whether we have to allow or not multiple GLOBALs elements
|
As far as I can tell, the requirement behind the multiple GLOBALs is something like: We've discussed this in terms of supporting 'dynamic reference resolution'. I'm not sure if this solution is satisfactory for other multiple GLOBALS usage. One point to consider re: allowing COLLECTION under GLOBALS is what does COLLECTION allow?
It would need be documented that theses were not allowed under the context of GLOBALS, much like the VM syntax restriction that COLUMN is not allowed under GLOBALS. |
For the record: |
Neither do I |
That is true. I was referring to your suggestion in Issue 6, which would preserve 1 GLOBAL and facilitate that issue as well. |
This can be changed. |
I've a little trouble that can be illustrated by your simple VOTable annotation I've extracted the code fragment below: <GLOBALS>
<INSTANCE dmtype="cube:SparseCube">
<COMPOSITION dmrole="cube:SparseCube.data">
<EXTINSTANCES>_cube1_data</EXTINSTANCES>
</COMPOSITION>
</INSTANCE>
</GLOBALS>
<TEMPLATES tableref="_cube1">
<INSTANCE dmtype="cube:NDPoint" ID="_cube1_data">
...
</INSTANCE>
</TEMPLATES>
It is not easy for the parser to work this out:
This issue was solved by my former TABLE_ROW_TEMPLATE, I'm afraid we have now to imagine something to replace it. |
EXTINSTANCES becomes JOIN in the merged syntax, and I think you get the simplicity you're looking for there. <GLOBALS>
<INSTANCE ID="_TimeSeries" dmtype="cube:SparseCube">
<ATTRIBUTE dmrole="cube:SparseCube.data">
<COLLECTION>
<JOIN tableref="Results" dmref="_cube1_data"/>
</COLLECTION>
</ATTRIBUTE>
</INSTANCE>
</GLOBALS>
<TEMPLATES tableref="Results">
<INSTANCE dmtype="cube:NDPoint" ID="_cube1_data">
...
</INSTANCE>
</TEMPLATES> |
👍 We have to be clear on what to do with TEMPLATES without tableref (for table with ID) |
Do you mean '(for table with no ID)'? The MIVOT document suggests using the 'name' as a fallback if the referenced element has no ID, which is fine for other elements, but I don't think that is an option for TABLE. |
I'm ok, I just remind us to mention explicitly the case.
|
agreed. |
No description provided.
The text was updated successfully, but these errors were encountered: