Unit tests - Coverage of last TC issues

[jackpoz]

Create unit tests for these issues:

• [Crash] Player::LoadFromDB TrinityCore/TrinityCore#15633
• Core/LFG: Readd to queue if proposal denied TrinityCore/TrinityCore#16279
• [3.3.5] Crash Exploit TrinityCore/TrinityCore#19128
• [3.3.5] Crash: StopCastingCharm TrinityCore/TrinityCore#23133
• Core/Unit: Guardians stop follow the player after a combat TrinityCore/TrinityCore#17981 (comment)
• https://github.com/jackpoz/BotFarm/tree/flooding_packets

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[dmpaul26]

Do I just write the tests in the tests folder of the test branch?

[jackpoz]

there's no tests folder or test branch, what are you talking about ? Currently there's https://github.com/jackpoz/BotFarm/tree/master/TrinityCore%20UnitTests project but it doesn't have any particular unit test, only a couple of PoCs

[dmpaul26]

Oh wow. I was on mobile and I followed this issue from TrinityCore/TrinityCore#16279. I didn't realize this was in a different repo. That PR is waiting for testing I assumed, would they be written here or in the TC repo?

[jackpoz]

TC repo currently doesn't have any kind of unit testing

[dmpaul26]

Yeah, that's what I thought too, that's why I was lost. Thanks, sorry for this.