Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiModel class (maybe not that name) #24

Open
jacobpennington opened this issue Aug 4, 2022 · 0 comments
Open

MultiModel class (maybe not that name) #24

jacobpennington opened this issue Aug 4, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@jacobpennington
Copy link
Owner

General idea would be to provide a simple wrapper class for composing Models similar to the way a Model composes Layers. This would not provide new functionality, it would just be a way to make Layer grouping explicit for complex Models. I think this would be fairly straightforward to implement. This could also make separate fitting of Layer groups more intuitive.

Ex: split LN into two models

linear_nonlinear = MultiModel(
    Model(WeightChannels(...), FIR(...)),  # Linear part
    Model(DoubleExponential(...))          # Nonlinear part
)

Ex: model with multiple "branches"

branched_model = MultiModel(
    [Model(WeightChannels(...), FIR(...)), Model(WeightChannels(...), StateGain(...))],
    Model(WeightedSum(...), DoubleExponential(...))
)
@jacobpennington jacobpennington added the enhancement New feature or request label Aug 4, 2022
@jacobpennington jacobpennington self-assigned this Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant