Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First array entry skipped when adding from array #9

Closed
jg110 opened this issue Oct 18, 2019 · 6 comments · May be fixed by #10
Closed

First array entry skipped when adding from array #9

jg110 opened this issue Oct 18, 2019 · 6 comments · May be fixed by #10
Labels
compiler-bug

Comments

@jg110
Copy link

jg110 commented Oct 18, 2019 •
edited by jacobwilliams
Loading

If csv_write_test.f90 is modified to construct an input array from array values, the first entry is ignored:

program csv_write_test

use csv_module
use iso_fortran_env, only: wp => real64

implicit none

type(csv_file) :: f
logical :: status_ok
real(wp), dimension(3) :: X = [1._wp, 2._wp, 3._wp]

! open the file
call f%open('test.csv',n_cols=4,status_ok=status_ok)

! add header
call f%add(['x','y','z','t'])
call f%next_row()

! add some data:
call f%add([X(1),X(2),X(3)],real_fmt='(F5.3)')
call f%add(.true.)
call f%next_row()
call f%add([4.0_wp,5.0_wp,6.0_wp],real_fmt='(F5.3)')
call f%add(.false.)
call f%next_row()

! finished
call f%close(status_ok)

end program csv_write_test

test.csv:

"x","y","z","t"
2.000,3.000,0.000,T
4.000,5.000,6.000,F
@jg110
Copy link
Author

jg110 commented Oct 18, 2019 •
edited by jacobwilliams
Loading

This problem is fixed by adding two lines to csv_module.F90 starting at line 519 (surrounding lines added for context):

#if defined __GFORTRAN__
        ! This is a stupid workaround for gfortran bugs (tested with 7.2.0)
        select type (val)
        type is (character(len=*))
            call me%add(val(i),int_fmt,real_fmt,trim_str)
        type is (real(wp))
            call me%add(val(i),int_fmt,real_fmt,trim_str)
        class default
            call me%add(val(i),int_fmt,real_fmt,trim_str)
        end select

The fix is similar to the one added for character inputs. This bug is especially confusing to me because I tried adding another do loop with a select type statement for inputs of type real(wp) and everything I tried inside the statement to output the value of i and val(i) came out correctly. It's like the iterator is being incremented by one when the add subroutine is called.

@jg110
Copy link
Author

jg110 commented Nov 29, 2019

After further testing I've verified that this bug doesn't occur with the Intel Fortran compiler.

@jacobwilliams
Copy link
Owner

jacobwilliams commented Nov 29, 2019 •
edited
Loading

What version off the compiler are you using? I don't see this bug with gfortran 9.1.

Also note: this issue is similar to #4

What do you get when you run the updated test on #10

@jacobwilliams jacobwilliams mentioned this issue Nov 29, 2019
Open
@jg110
Copy link
Author

jg110 commented Dec 18, 2019

I'm using gfortran 9.2.1 from the Fedora 31 package set. I'll try the updated test and report back.

@jg110
Copy link
Author

jg110 commented Jan 12, 2020

Sorry it took me a while to get back to this. I'm still getting this issue with the other branch when I replace csv_write_test.f90 with the program in my first post.

@jg110
Copy link
Author

jg110 commented Jul 14, 2022

Following up on this, it was a bug in older versions of gfortran. With a sufficiently new version (tested with 11.2.1) the above code will generate the correct CSV file:

"x","y","z","t"
1.000,2.000,3.000,T
4.000,5.000,6.000,F

@jg110 jg110 closed this as completed Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gfortran bugs jacobwilliams/csv-fortran
2 participants
@jacobwilliams @jg110