From dc8e6fd34cc305888a3c68f03013da49f9d797fd Mon Sep 17 00:00:00 2001 From: THEBUSTED Date: Tue, 20 Apr 2021 09:18:59 +0700 Subject: [PATCH] Fix undefined variable On the method historicalTrades variable $fromTradeId is undefined. Change $fromTradeId to $tradeId --- php-binance-api.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/php-binance-api.php b/php-binance-api.php index ef85cfa..48c70e0 100755 --- a/php-binance-api.php +++ b/php-binance-api.php @@ -910,7 +910,7 @@ public function historicalTrades(string $symbol, int $limit = 500, int $tradeId "symbol" => $symbol, "limit" => $limit, ]; - if ($fromTradeId > 0) { + if ($tradeId > 0) { $parameters["fromId"] = $tradeId; } else { // if there is no tradeId given, we can use v3/trades, weight is 1 and not 5