Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asynchronous support #60

Open
epenet opened this issue May 5, 2020 · 2 comments
Open

Asynchronous support #60

epenet opened this issue May 5, 2020 · 2 comments

Comments

@epenet
Copy link
Contributor

epenet commented May 5, 2020 •
edited
Loading

Hi,

Home Assistant now raise warnings if components use I/O inside the event loop and recommend that all modules are migrated to Asynchronous.

Do you have plans to add Async support to pyze? If there are no such plans, is it something you'd consider adding if I were to provide a PR?

My Home Assistant module relies on your module and it would a shame to have to create a new project just for adding Async support...
@epenet
Copy link
Contributor Author

epenet commented May 11, 2020

I've started an Async branch on my repo.
Does the style fit your design?

This was referenced May 13, 2020
Closed
Closed
@epenet
Copy link
Contributor Author

epenet commented May 13, 2020

The PR currently implements async only on the API side, but I have an async implementation of the pyze client stashed on my machine also. Is that something of interest for the community?

@epenet epenet mentioned this issue Jun 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@epenet