Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlikely argument type String for containsKey(Object) on a Map<EmailTemplate.EmailTemplatePart,String> #42

Open
ritonglue opened this issue Oct 22, 2024 · 0 comments · May be fixed by #43
Open

Unlikely argument type String for containsKey(Object) on a Map<EmailTemplate.EmailTemplatePart,String> #42

ritonglue opened this issue Oct 22, 2024 · 0 comments · May be fixed by #43

Comments

@ritonglue
Copy link

In org.example.kickoff.business.email.EmailService in method buildTemplateContent one can read

Arrays.stream(EmailTemplatePart.values())
	.filter(part -> !templateParts.containsKey(part.getKey()))
	.forEach(part -> templateParts.putIfAbsent(part, emailTemplateService.build(templateEmail, part, messageParameters)));

I think this should be
.filter(part -> !templateParts.containsKey(part))
ritonglue pushed a commit to ritonglue/java-ee-kickoff-app that referenced this issue Oct 28, 2024
Fixes javaeekickoff#42 : unlikely argument for containsKey. Key is Em…
24fec75 
…ailTemplatePart
@ritonglue ritonglue linked a pull request Oct 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ritonglue